WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

fix(connector): [payload] RSync throwing 404 and re-use existing util functions #10542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
likhinbopanna merged 3 commits into from
Dec 9, 2025
Merged

fix(connector): [payload] RSync throwing 404 and re-use existing util functions #10542

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51db6a3
refactor: use existing util functions instead
pixincreate Dec 4, 2025
ad77fef
fix: refund throwing 4xx during psync
pixincreate Dec 4, 2025
a6fa5a7
remove
pixincreate Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions crates/hyperswitch_connectors/src/connectors/payload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,11 @@ use hyperswitch_interfaces::{
use masking::{ExposeInterface, Mask};
use transformers as payload;

use crate::{constants::headers, types::ResponseRouterData, utils};
use crate::{
constants::headers,
types::ResponseRouterData,
utils::{self, PaymentsSyncRequestData, RefundsRequestData},
};

#[derive(Clone)]
pub struct Payload {
Expand Down Expand Up @@ -461,12 +465,7 @@ impl ConnectorIntegration<PSync, PaymentsSyncData, PaymentsResponseData> for Pay
req: &PaymentsSyncRouterData,
connectors: &Connectors,
) -> CustomResult<String, errors::ConnectorError> {
let payment_id = req
.request
.connector_transaction_id
.get_connector_transaction_id()
.change_context(errors::ConnectorError::MissingConnectorTransactionID)?;

let payment_id = req.request.get_connector_transaction_id()?;
Ok(format!(
"{}/transactions/{}",
self.base_url(connectors),
Expand Down Expand Up @@ -797,11 +796,7 @@ impl ConnectorIntegration<RSync, RefundsData, RefundsResponseData> for Payload {
req: &RefundSyncRouterData,
connectors: &Connectors,
) -> CustomResult<String, errors::ConnectorError> {
let connector_refund_id = req
.request
.connector_refund_id
.as_ref()
.ok_or_else(|| errors::ConnectorError::MissingConnectorRefundID)?;
let connector_refund_id = req.request.get_connector_refund_id()?;
Ok(format!(
"{}/transactions/{}",
self.base_url(connectors),
Expand All @@ -820,9 +815,6 @@ impl ConnectorIntegration<RSync, RefundsData, RefundsResponseData> for Payload {
.url(&types::RefundSyncType::get_url(self, req, connectors)?)
.attach_default_headers()
.headers(types::RefundSyncType::get_headers(self, req, connectors)?)
.set_body(types::RefundSyncType::get_request_body(
self, req, connectors,
)?)
.build(),
))
}
Expand Down
Loading