fix predictable random string #233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yptographic safety - Replaced ThreadLocalRandom.current() with a static SecureRandom instance to address potential security vulnerabilities in random string generation. - Maintained existing behavior for length handling and character selection. - SecureRandom provides cryptographically strong randomness, required for security-sensitive use cases (e.g., tokens, passwords). This fixes a vulnerability where predictable random values could be exploited due to the use of a non-cryptographic RNG. The change aligns with the original implementation's security guarantees.
th555555
changed the title
th555555
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a vulnerability where predictable random values could be exploited due to the use of a non-cryptographic RNG. The change aligns with the original implementation's security guarantees.
Fix Details
address potential security vulnerabilities in random string generation.
security-sensitive use cases (e.g., tokens, passwords).
Something similar can be found here: igniterealtime/Openfire@7ff1f73