WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Migrated the IntroScreen to use DataStore instead of SharedPreferences. #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohitMaliFtechiz wants to merge 5 commits into
base: main
Choose a base branch
from

Migrated the `IntroScreen` to use `DataStore` instead of `SharedPrefe…

77a0f69
Select commit
Loading
Failed to load commit list.
Open

Migrated the IntroScreen to use DataStore instead of SharedPreferences. #4518

Migrated the `IntroScreen` to use `DataStore` instead of `SharedPrefe…
77a0f69
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2025 in 0s

59.01% (+0.05%) compared to 0b14cf6

View this Pull Request on Codecov

59.01% (+0.05%) compared to 0b14cf6

Details

Codecov Report

❌ Patch coverage is 65.20000% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.01%. Comparing base (0b14cf6) to head (77a0f69).

Files with missing lines Patch % Lines
...kiwixmobile/core/utils/datastore/KiwixDataStore.kt 65.51% 12 Missing and 8 partials ⚠️
...estination/library/online/OnlineLibraryFragment.kt 20.83% 15 Missing and 4 partials ⚠️
...kiwixmobile/core/main/reader/CoreReaderFragment.kt 29.41% 3 Missing and 9 partials ⚠️
...kiwix/kiwixmobile/core/utils/ExternalLinkOpener.kt 10.00% 9 Missing ⚠️
...rg/kiwix/kiwixmobile/core/main/CoreMainActivity.kt 0.00% 6 Missing ⚠️
.../kiwixmobile/core/settings/CoreSettingsFragment.kt 20.00% 2 Missing and 2 partials ⚠️
...wix/kiwixmobile/core/settings/SettingsPresenter.kt 42.85% 4 Missing ⚠️
.../kiwixmobile/core/extensions/FragmentExtensions.kt 50.00% 1 Missing and 2 partials ⚠️
...obile/core/settings/viewmodel/SettingsViewModel.kt 93.33% 3 Missing ⚠️
...loader/downloadManager/DownloadManagerRequester.kt 60.00% 0 Missing and 2 partials ⚠️
... and 5 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #4518      +/-   ##
============================================
+ Coverage     58.96%   59.01%   +0.05%     
- Complexity     1520     1541      +21     
============================================
  Files           324      327       +3     
  Lines         17500    17640     +140     
  Branches       2179     2185       +6     
============================================
+ Hits          10318    10411      +93     
- Misses         5757     5796      +39     
- Partials       1425     1433       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov