WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@sjd78
Copy link
Member

@sjd78 sjd78 commented Jun 13, 2025

With konveyor/tackle-ui-tests#1543, it is possible to provide the default admin user password that needs to be changed on first login. While the test configs embed the default username and password, it is useful to explicitly define them in the workflow so we know exactly what is being used.

Use the same ingress wait as https://github.com/konveyor/tackle-ui-tests/blob/6a7e88b54e63d15e122441a2bef1fe123a7a6a7f/.github/workflows/run-ui-tests.yaml#L85-L95

Summary by CodeRabbit

  • Chores
    • Updated environment variables used in UI integration tests for login credentials.
    • Improved the reliability and efficiency of UI service readiness checks during testing.

@sjd78 sjd78 requested review from abrugaro and aufi June 13, 2025 15:13
With konveyor/tackle-ui-tests#1543,
it is possible to provide the default admin user password
that needs to be changed on first login.  While the test
configs embed the default username and password, it is useful
to explicitly define them in the workflow so we know
exactly what is being used.

Signed-off-by: Scott J Dickerson <[email protected]>
@sjd78 sjd78 force-pushed the e2e_ui_login_tests_update branch from 74009e1 to 3cd2be1 Compare July 17, 2025 21:35
@coderabbitai
Copy link

coderabbitai bot commented Jul 17, 2025

Walkthrough

The Kubernetes ingress readiness check in two GitHub Actions workflows was simplified by replacing manual polling loops with a single kubectl wait command with a 600-second timeout. The UI URL environment variable now uses the Minikube IP directly. Additionally, Cypress login test environment variables were updated from one password variable to two distinct password variables.

Changes

File(s) Change Summary
.github/workflows/global-ci-bundle.yml,
.github/workflows/global-ci.yml
Simplified ingress wait step using kubectl wait; set UI URL with Minikube IP; replaced CYPRESS_pass with CYPRESS_initialPassword and CYPRESS_password in Cypress test environment variables.

Poem

The workflows now know two secrets, not one—
For Cypress logins, the tests have begun!
Initial and current, their passwords are set,
In YAML they wait, with no sign of sweat.
Rabbits approve, with a hop and a cheer,
Secure little changes—our tests persevere! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3cd2be1 and 73eacfe.

📒 Files selected for processing (2)
  • .github/workflows/global-ci-bundle.yml (1 hunks)
  • .github/workflows/global-ci.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/global-ci.yml
  • .github/workflows/global-ci-bundle.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sjd78 sjd78 changed the title Update UI login test initial/password configs Update UI login test initial/password configs and ingress wait Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant