-
Notifications
You must be signed in to change notification settings - Fork 13
Update UI login test initial/password configs and ingress wait #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
With konveyor/tackle-ui-tests#1543, it is possible to provide the default admin user password that needs to be changed on first login. While the test configs embed the default username and password, it is useful to explicitly define them in the workflow so we know exactly what is being used. Signed-off-by: Scott J Dickerson <[email protected]>
74009e1 to
3cd2be1
Compare
WalkthroughThe Kubernetes ingress readiness check in two GitHub Actions workflows was simplified by replacing manual polling loops with a single Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: Scott J Dickerson <[email protected]>
With konveyor/tackle-ui-tests#1543, it is possible to provide the default admin user password that needs to be changed on first login. While the test configs embed the default username and password, it is useful to explicitly define them in the workflow so we know exactly what is being used.
Use the same ingress wait as https://github.com/konveyor/tackle-ui-tests/blob/6a7e88b54e63d15e122441a2bef1fe123a7a6a7f/.github/workflows/run-ui-tests.yaml#L85-L95
Summary by CodeRabbit