WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

🍒 [release-0.8] Use CI shared folder to load expected analysis output (#355) #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mguetta1 wants to merge 3 commits into
base: release-0.8
Choose a base branch
from
Draft

🍒 [release-0.8] Use CI shared folder to load expected analysis output (#355) #367

mguetta1 wants to merge 3 commits into from

Conversation

@mguetta1
Copy link
Collaborator

@mguetta1 mguetta1 commented Nov 5, 2025

Cherry-picks: #355

@mguetta1
Use CI shared folder to load expected analysis output (konveyor#355)
551878b 
* Adding functionality to parse expected output from yaml

Signed-off-by: Maayan Hadasi <[email protected]>

* Adding book-server source-only analysis

Signed-off-by: Maayan Hadasi <[email protected]>

* Changes after AI review

Signed-off-by: Maayan Hadasi <[email protected]>

* Modifying book-server_deps analysis to use shared output file

Signed-off-by: Maayan Hadasi <[email protected]>

* Check got incident file by strings.HasSuffix

Signed-off-by: Maayan Hadasi <[email protected]>

* Record non-mandatory insights

Signed-off-by: Maayan Hadasi <[email protected]>

* Update README

Signed-off-by: Maayan Hadasi <[email protected]>

* Skip test

Signed-off-by: Maayan Hadasi <[email protected]>

* Adding comment in analysis test case

Signed-off-by: Maayan Hadasi <[email protected]>

---------

Signed-off-by: Maayan Hadasi <[email protected]>
@mguetta1 mguetta1 requested a review from aufi November 5, 2025 08:41
@coderabbitai
Copy link

coderabbitai bot commented Nov 5, 2025 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mguetta1 mguetta1 marked this pull request as draft November 5, 2025 09:53
@mguetta1
Copy link
Collaborator Author

mguetta1 commented Nov 5, 2025

Converted to draft - not sure if this has any priority

aufi
aufi approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me and makes sense to get into 0.8 IMO.

One question is on shared test cases, that come from konveyor/ci repo that is not typically branched by releases. Its github workflows are defined on main branch for all relevant release branches; but shared_tests might make sense be branched (unless it is referenced to a defined commit until updated pulled)). Just thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aufi aufi aufi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mguetta1 @aufi