WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@shawn-hurley
Copy link
Contributor

@shawn-hurley shawn-hurley commented Dec 2, 2025

Currently, we have to manually do this, to take any changes from this base image, and this has led to many issues with debugging CI. Automatically doing this, will help keeps things sane.

Summary by CodeRabbit

  • Chores
    • Added automated workflow job to GitHub Actions that triggers coordinated image rebuilds across related repositories using token-based repository dispatch.

✏️ Tip: You can customize this high-level summary in your review settings.

Currently, we have to manually do this, to take any changes from this
base image, and this has led to many issues with debugging CI.
Automatically doing this, will help keeps things sane.

Signed-off-by: Shawn Hurley <[email protected]>
@shawn-hurley shawn-hurley requested a review from djzager December 2, 2025 15:52
@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2025

Walkthrough

A new GitHub Actions job named build_image_analyzer is added to the image-build workflow. It obtains an application token and uses repository dispatch to trigger a rebuild-java-provider event on the konveyor/analyzer-lsp repository, passing the current Git reference.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Enhancement
\.github/workflows/image-build.yaml``
Added new build_image_analyzer job that obtains an application token via peter-murray/workflow-application-token-action and triggers a repository dispatch event (rebuild-java-provider) on konveyor/analyzer-lsp repository with the current Git ref as payload.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify that the konveyor/analyzer-lsp repository has an active workflow or trigger listening for the rebuild-java-provider repository dispatch event
  • Confirm the application token permissions and scope are adequate for triggering repository dispatch on the target repository
  • Validate the Git ref payload format matches the expectations of the downstream workflow

Poem

🐰 A token hops through workflows bright,
Dispatching events to the analyzer's might,
Java providers rebuild anew,
Images fresh, the pipeline goes through!
Hop, trigger, rebuild—what a sight!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding automation to request a Java provider rebuild after image build, which matches the workflow modification in .github/workflows/image-build.yaml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2cf135d and 97e4cd9.

📒 Files selected for processing (1)
  • .github/workflows/image-build.yaml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.9)
.github/workflows/image-build.yaml

39-39: could not parse as YAML: could not find expected ':'

(syntax-check)

🪛 YAMLlint (1.37.1)
.github/workflows/image-build.yaml

[error] 40-40: syntax error: could not find expected ':'

(syntax)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: JDT.LS Integration Tests (Phase 2)
  • GitHub Check: Build tackle2-addon-analyzer
🔇 Additional comments (1)
.github/workflows/image-build.yaml (1)

28-45: Add explicit dependency on image-build job.

The PR objective states this job should run "after image build", but there's no explicit needs: dependency. GitHub Actions runs jobs in parallel by default. If the analyzer-lsp rebuild requires the newly built image to be published first, add needs: image-build to ensure sequential execution.

   build_image_analyzer:
     name: trigger java provider rebuild
+    needs: image-build
     runs-on: ubuntu

Signed-off-by: Shawn Hurley <[email protected]>
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visack

@shawn-hurley shawn-hurley merged commit 2caa345 into konveyor:main Dec 3, 2025
10 of 11 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants