-
Notifications
You must be signed in to change notification settings - Fork 20
👻 Adding ability to ask for java provider rebuild after image build #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👻 Adding ability to ask for java provider rebuild after image build #196
Conversation
Currently, we have to manually do this, to take any changes from this base image, and this has led to many issues with debugging CI. Automatically doing this, will help keeps things sane. Signed-off-by: Shawn Hurley <[email protected]>
WalkthroughA new GitHub Actions job named Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/image-build.yaml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.9)
.github/workflows/image-build.yaml
39-39: could not parse as YAML: could not find expected ':'
(syntax-check)
🪛 YAMLlint (1.37.1)
.github/workflows/image-build.yaml
[error] 40-40: syntax error: could not find expected ':'
(syntax)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: JDT.LS Integration Tests (Phase 2)
- GitHub Check: Build tackle2-addon-analyzer
🔇 Additional comments (1)
.github/workflows/image-build.yaml (1)
28-45: Add explicit dependency onimage-buildjob.The PR objective states this job should run "after image build", but there's no explicit
needs:dependency. GitHub Actions runs jobs in parallel by default. If the analyzer-lsp rebuild requires the newly built image to be published first, addneeds: image-buildto ensure sequential execution.build_image_analyzer: name: trigger java provider rebuild + needs: image-build runs-on: ubuntu
Signed-off-by: Shawn Hurley <[email protected]>
djzager
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
visack
Currently, we have to manually do this, to take any changes from this base image, and this has led to many issues with debugging CI. Automatically doing this, will help keeps things sane.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.