WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@chuangw6
Copy link

@chuangw6 chuangw6 commented Dec 5, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Add initial controller implementation.

    Note: Currently, the controller just reconciles the resources, but doesn't translate them to envoy config, which will be added in follow-up PRs.

  • Add translator code that translates GW resources to Envoy config.

    Note: this code is not connected to controller yet and needs some updates in follow-up PRs

Which issue(s) this PR fixes:

#19

Does this PR introduce a user-facing change?:

Initial controller implementation.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 5, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @chuangw6. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 5, 2025
@chuangw6 chuangw6 changed the title Add initial controller code and deployment files Add initial controller code and translator code Dec 8, 2025
@chuangw6 chuangw6 changed the title Add initial controller code and translator code Add initial controller code and translator logic Dec 8, 2025
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me overall with two nits!
will lgtm once you get a chance to fix that

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2025
@chuangw6 chuangw6 force-pushed the controller branch 2 times, most recently from a959735 to aa71fc0 Compare December 8, 2025 21:31
@david-martin
Copy link
Contributor

@chuangw6 Is this in essence a partial Gateway API implementation that will use envoy proxy as the underlying gateway,
with an implementation for the proposed APIs (AccessPolicy and Backend)?

@chuangw6
Copy link
Author

chuangw6 commented Dec 8, 2025

@chuangw6 Is this in essence a partial Gateway API implementation that will use envoy proxy as the underlying gateway, with an implementation for the proposed APIs (AccessPolicy and Backend)?

Yes, this is correct! @david-martin

@LiorLieberman
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2025
@chuangw6 chuangw6 force-pushed the controller branch 2 times, most recently from 0297e32 to c1ae87e Compare December 8, 2025 23:57
sharedGwInformers := gatewayinformers.NewSharedInformerFactory(gatewayClientset, 60*time.Second)
sharedAgenticInformers := agenticinformers.NewSharedInformerFactory(agenticClientset, 60*time.Second)

jwtIssuer, err := discovery.JWTIssuer(cfg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I donot understand here, why does it read from k8s, oss k8s seems no such endpoint?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, I think it's available when the SA volume projection is enabled per https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#service-account-issuer-discovery.

And SA volume projection is required to allow the client application Pod (i.e. MCP client) to surface its token.

@LiorLieberman
Copy link
Member

This looks good as another foundation for the controller. Thanks @chuangw6!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuangw6, LiorLieberman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 46b13c8 into kubernetes-sigs:prototype Dec 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants