-
Notifications
You must be signed in to change notification settings - Fork 9
Add initial controller code and translator logic #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @chuangw6. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
LiorLieberman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me overall with two nits!
will lgtm once you get a chance to fix that
a959735 to
aa71fc0
Compare
|
@chuangw6 Is this in essence a partial Gateway API implementation that will use envoy proxy as the underlying gateway, |
Yes, this is correct! @david-martin |
|
/ok-to-test |
0297e32 to
c1ae87e
Compare
| sharedGwInformers := gatewayinformers.NewSharedInformerFactory(gatewayClientset, 60*time.Second) | ||
| sharedAgenticInformers := agenticinformers.NewSharedInformerFactory(agenticClientset, 60*time.Second) | ||
|
|
||
| jwtIssuer, err := discovery.JWTIssuer(cfg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I donot understand here, why does it read from k8s, oss k8s seems no such endpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's standard OIDC discovery endpoint per https://kubernetes.io/docs/reference/config-api/apiserver-config.v1/#apiserver-config-k8s-io-v1-Issuer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, I think it's available when the SA volume projection is enabled per https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#service-account-issuer-discovery.
And SA volume projection is required to allow the client application Pod (i.e. MCP client) to surface its token.
Signed-off-by: Chuang Wang <[email protected]>
|
This looks good as another foundation for the controller. Thanks @chuangw6! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuangw6, LiorLieberman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
#19
Does this PR introduce a user-facing change?: