WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@evanrolfe
Copy link

The current router implementation does not allow for colons in the route if they are immediately following a path parameter, this prevents us from following the Google API specification.

For example, I was unable to define a route which would match a URL like this: POST /files/1234:delete where 1234 should map to a :fileId path param. This PR fixes that.

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.04%. Comparing base (f24aaff) to head (8b6130a).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2847      +/-   ##
==========================================
+ Coverage   93.25%   94.04%   +0.79%     
==========================================
  Files          39       39              
  Lines        4652     3826     -826     
==========================================
- Hits         4338     3598     -740     
+ Misses        218      134      -84     
+ Partials       96       94       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants