WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@stefonarch
Copy link
Contributor

immagine

@stefonarch
Copy link
Contributor Author

stefonarch commented Dec 16, 2025

I noticed that without using QLabel the order is reverted, the checkbox comes before the text. Should they be added for consistency?

Noticed only now that

         <decoration>server</decoration>
             <gap>0</gap>

could go well here too.

@johanmalm
Copy link
Member

Thanks.

Thoughts:

  1. It feels like we ought to settle on a policy for
    a. What type of layout we use. I think I prefer QFormLayout
    b. Use of QGroupBox to group similar settings together
    c. Do we use a QLabel on the left and associated QWidget on the right (as most of it is); or do we organise it some other way like QLabel on top and QWidget below (which I think is more modern on webpages, etc).
  2. For the new appearance settings, we ought to be quite thoughtful about how the settings are organised. For example, it doesn't feel that obvious what "Keep Border" means.
  3. Consider moving "Keep Border" to behaviour.
  4. Consider creating a tristate QComboBox for DropShadows ("Disabled", "Enabled except on tiled windows", "Enabled on all windows".

I don't know much about UI design, but feel it's worth pondering this before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants