WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Nov 25, 2025

Summary

Fixes #13214 by disabling the ctrl-click handler for links on MacOS.

Manual testing

MacOS

  1. Add https://example.com/ to a note.
  2. From the Markdown editor, cmd-click the just-added link. Verify that this opens example.com in a web browser.
  3. Repeat step 1 for ctrl-click.
  4. Add a checklist item to the note with - [ ] test.
  5. Verify that cmd-click toggles the checklist item, but ctrl-click does not.
  6. For testing, hardcode preferMacShortcuts to false, then restart the desktop app.
  7. Verify that ctrl-click toggles the checklist item.
  8. Verify that ctrl-click opens the in-note link.

@personalizedrefrigerator personalizedrefrigerator marked this pull request as draft November 25, 2025 20:09
@personalizedrefrigerator personalizedrefrigerator marked this pull request as ready for review December 1, 2025 19:18
@laurent22 laurent22 merged commit 1c7b0e6 into laurent22:dev Dec 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown editor should handle Ctrl+Click on links

2 participants