Mobile: Prevent opening the edit / delete dialog when long pressing the conflicts notebook #13860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjo118
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on the mobile app, when the conflicts notebook is present, it is possible to access a delete button on the notebook when long pressing the notebook. Pressing the delete button will do nothing, without prompting any kind of error. You can also access the option to rename the notebook, but you will get an error if you attempt to change it.
conflicts.before.mp4
This PR prevents opening the edit / delete dialog when long pressing the conflicts notebook, to avoid giving the user options to do actions which don't actually work.
Testing
See video:
conflicts.after.mp4