url: reduce allocations in ParseURL #935
Closed
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use e.g. "postgres://" as the connection string, ParseURL will be called and the result will be computed each time a connection is established to the database. This can be expensive because a new strings.Replacer is created each time ParseURL is called. It's also unnecessary because the output can be computed by the input and for most processes only a single input will ever exist for the lifetime of the process. Reuse the same *Replacer across calls, and also cache the first 100 unique results from ParseURL, to speed up the second and third calls.
Contributor
Author
|
Tested this locally, it's working fine. |
Collaborator
|
Same comment from over here applies: no concrete benchmarks, and not convinced it's worth optimising this. Since this is a few years old and the author has not been active on GitHub for several years, I'll just go ahead and close it. But feel free to come back and we can re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use e.g. "postgres://" as the connection string, ParseURL will
be called and the result will be computed each time a connection is
established to the database. This can be expensive because a new
strings.Replacer is created each time ParseURL is called. It's also
unnecessary because the output can be computed by the input and for
most processes only a single input will ever exist for the lifetime of
the process.
Reuse the same *Replacer across calls, and also cache the first 100
unique results from ParseURL, to speed up the second and third calls.