fix: replace NaN% with 0.0% when all translations complete #1318

lokyaan · 2025-10-29T20:04:13Z

Summary

Fixes a division-by-zero issue in the lingo.dev status CLI output.
When totalWordsToTranslate equals 0, (0 / 0) * 100 evaluates to NaN, causing the CLI to print:

Fix

Added a guard to return 0.0 instead of NaN when total words = 0:

const percent =
  totalWordsToTranslate === 0
    ? 0.0
    : ((words / totalWordsToTranslate) * 100).toFixed(1);


###Result
- fr: ~0 words (0.0% of total)

###Impact
Prevents CI/CD regex validation failures.
Improves CLI reliability and output consistency.

The-Best-Codes

Just a couple of things I see that you might want to change.
Also, not sure if you ran pnpm run format before committing but don't forget to do that 🙂

The-Best-Codes · 2025-10-30T02:31:11Z

package-lock.json

This file needs to be removed, the repo uses pnpm

The-Best-Codes · 2025-10-30T02:31:59Z

package.json

  "dependencies": {
    "@changesets/changelog-github": "^0.5.0",
    "@changesets/cli": "^2.27.10",
+    "build": "^0.1.4",


Why is this change needed?

lokyaan · 2025-10-30T07:19:58Z

Hi!!! Glad to see the review So These are the following changes I made after this email 1. Removed package.json 2. The "build": "^0.1.4" got added due to dependency issue and this is currently not present in the code And right now I made sure to run pnpm run format before committing Thank Youuuu

…

On Thu, 30 Oct 2025 at 08:07, BestCodes ***@***.***> wrote: ***@***.**** requested changes on this pull request. Just a couple of things I see that you might want to change. Also, not sure if you ran pnpm run format before committing but don't forget to do that 🙂 ------------------------------ On package-lock.json <#1318 (comment)> : This file needs to be removed, the repo uses pnpm ------------------------------ In package.json <#1318 (comment)> : > @@ -27,6 +27,7 @@ "dependencies": { ***@***.***/changelog-github": "^0.5.0", ***@***.***/cli": "^2.27.10", + "build": "^0.1.4", Why is this change needed? — Reply to this email directly, view it on GitHub <#1318 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDTA2HORQJCJWAQACFV6FI332F2YJAVCNFSM6AAAAACKS47ITSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGOJXGIYTKMBYGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

lokyaan · 2025-10-30T16:42:58Z

Hiiiii Lingo.dev Any update regarding this???? On Thu, 30 Oct, 2025, 12:49 LOKYAAN ABINETRE KOTI, ***@***.***> wrote:

…

Hi!!! Glad to see the review So These are the following changes I made after this email 1. Removed package.json 2. The "build": "^0.1.4" got added due to dependency issue and this is currently not present in the code And right now I made sure to run pnpm run format before committing Thank Youuuu On Thu, 30 Oct 2025 at 08:07, BestCodes ***@***.***> wrote: > ***@***.**** requested changes on this pull request. > > Just a couple of things I see that you might want to change. > Also, not sure if you ran pnpm run format before committing but don't > forget to do that 🙂 > ------------------------------ > > On package-lock.json > <#1318 (comment)> > : > > This file needs to be removed, the repo uses pnpm > ------------------------------ > > In package.json > <#1318 (comment)> > : > > > @@ -27,6 +27,7 @@ > "dependencies": { > ***@***.***/changelog-github": "^0.5.0", > ***@***.***/cli": "^2.27.10", > + "build": "^0.1.4", > > Why is this change needed? > > — > Reply to this email directly, view it on GitHub > <#1318 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BDTA2HORQJCJWAQACFV6FI332F2YJAVCNFSM6AAAAACKS47ITSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGOJXGIYTKMBYGM> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

The-Best-Codes · 2025-10-30T18:28:28Z

@lokyaan I want to test this locally to see if the build dependency is actually needed on my end. AFAIK it works just fine without it.

lokyaan · 2025-10-30T19:03:10Z

Yess it works when i tested it again after removing the dependency

…

On Thu, 30 Oct, 2025, 23:58 BestCodes, ***@***.***> wrote: *The-Best-Codes* left a comment (lingodotdev/lingo.dev#1318) <#1318 (comment)> @lokyaan <https://github.com/lokyaan> I want to test this locally to see if the build dependency is actually needed on my end. AFAIK it works just fine without it. — Reply to this email directly, view it on GitHub <#1318 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDTA2HJ3DTMEXXPLQ7BKO7332JKGDAVCNFSM6AAAAACKS47ITSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINRZGQ3DQNBRGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

The-Best-Codes · 2025-10-30T23:56:46Z

@lokyaan Okay, maybe remove the dependency, then :)

lokyaan · 2025-10-31T06:51:49Z

Hiii @lingodotdev/lingo.dev ***@***.***> I thought I already did it and realised I was looking into another package.json I found out what u were referring to and removed the build dependency and run it again and pushed the code Thank You

…

On Fri, 31 Oct, 2025, 05:27 BestCodes, ***@***.***> wrote: *The-Best-Codes* left a comment (lingodotdev/lingo.dev#1318) <#1318 (comment)> @lokyaan <https://github.com/lokyaan> Okay, maybe remove the dependency, then :) — Reply to this email directly, view it on GitHub <#1318 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDTA2HO3JCJ4E2BUGHNEGET32KQVLAVCNFSM6AAAAACKS47ITSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINZQG42DGNJQGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

The-Best-Codes · 2025-10-31T15:50:05Z

@lokyaan Don't forget to run pnpm install to update the lockfile and pnpm run format to format the codebase again. After that I think this PR is ready to merge 😀

lokyaan · 2025-10-31T17:28:41Z

After running these two commands, I got a lot of files that needs to be committed. Should I add, commit and push all those to my branch??? I'm sry that this is taking time but I'm a bit confused at this point if I'm dng that right

…

On Fri, 31 Oct 2025 at 21:20, BestCodes ***@***.***> wrote: *The-Best-Codes* left a comment (lingodotdev/lingo.dev#1318) <#1318 (comment)> @lokyaan <https://github.com/lokyaan> Don't forget to run pnpm install to update the lockfile and pnpm run format to format the codebase again. After that I think this PR is ready to merge 😀 — Reply to this email directly, view it on GitHub <#1318 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDTA2HIOQNN6TOOTWAS7WQD32OAMHAVCNFSM6AAAAACKS47ITSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINZTG4YTIOJRGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

The-Best-Codes

Looks good to me!

lokyaan · 2025-10-31T18:52:10Z

Awesome, thanks!

…

On Sat, 1 Nov 2025 at 00:21, BestCodes ***@***.***> wrote: ***@***.**** approved this pull request. Looks good to me! — Reply to this email directly, view it on GitHub <#1318 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDTA2HMVXUGNBWF3LKDAVXD32OVSTAVCNFSM6AAAAACKS47ITSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIMBVG4YDGOJRGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Copilot

Pull Request Overview

This PR fixes a division-by-zero bug in the lingo.dev status CLI command that caused "NaN%" to appear in the output when all translations are complete (totalWordsToTranslate = 0). The fix adds a guard condition to return 0.0 instead of the result of dividing zero by zero.

Key Changes:

Added conditional check in status command to handle edge case when totalWordsToTranslate === 0
Updated pnpm-lock.yaml with dependency resolution changes (unrelated to main fix)

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`packages/cli/src/cli/cmd/status.ts`	Added guard condition to prevent NaN% when calculating per-language translation percentages with zero total words
`pnpm-lock.yaml`	Dependency resolution updates for eslint-related packages (unrelated to the main fix)

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-12T02:41:55Z

packages/cli/src/cli/cmd/status.ts

-          const percent = ((words / totalWordsToTranslate) * 100).toFixed(1);
+          const percent =
+            totalWordsToTranslate === 0
+              ? 0.0


The ternary operator has a type inconsistency. The true branch returns 0.0 (a number), while the false branch returns the result of .toFixed(1) (a string). This should be "0.0" (a string) to match the type returned by .toFixed(1).

const percent = totalWordsToTranslate === 0 ? "0.0" : ((words / totalWordsToTranslate) * 100).toFixed(1);

Suggested change

? 0.0

? "0.0"

fix: replace NaN% with 0.0% when all translations complete

f61594b

The-Best-Codes suggested changes Oct 30, 2025

View reviewed changes

fix(cli): prevent NaN% by returning 0.0 when totalWordsToTranslate is 0

cc0f4e9

chore(package): remove unnecessary build dependency from package.json

a930dfe

lokyaan added 2 commits October 31, 2025 23:47

chore(deps): update pnpm lockfile

e20a46e

chore(format): modified status.ts

6828767

The-Best-Codes approved these changes Oct 31, 2025

View reviewed changes

maxprilutskiy requested a review from Copilot November 12, 2025 02:39

Copilot started reviewing on behalf of maxprilutskiy November 12, 2025 02:40 View session

Copilot finished reviewing on behalf of maxprilutskiy November 12, 2025 02:41

Copilot AI reviewed Nov 12, 2025

View reviewed changes

fix: replace NaN% with 0.0% when all translations complete #1318

Are you sure you want to change the base?

fix: replace NaN% with 0.0% when all translations complete #1318

Uh oh!

Conversation

lokyaan commented Oct 29, 2025

Summary

Fix

Uh oh!

The-Best-Codes left a comment

Choose a reason for hiding this comment

Uh oh!

The-Best-Codes Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

The-Best-Codes Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

lokyaan commented Oct 30, 2025 via email

Uh oh!

lokyaan commented Oct 30, 2025 via email

Uh oh!

The-Best-Codes commented Oct 30, 2025

Uh oh!

lokyaan commented Oct 30, 2025 via email

Uh oh!

The-Best-Codes commented Oct 30, 2025

Uh oh!

lokyaan commented Oct 31, 2025 via email

Uh oh!

The-Best-Codes commented Oct 31, 2025

Uh oh!

lokyaan commented Oct 31, 2025 via email

Uh oh!

The-Best-Codes left a comment

Choose a reason for hiding this comment

Uh oh!

lokyaan commented Oct 31, 2025 via email

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants