-
Notifications
You must be signed in to change notification settings - Fork 662
chore(ci): add matrix workflow to build demo apps [skip i18n] #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
amankamlesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krsunny99 can you send link of your github action showing workspace running fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new GitHub Actions workflow to build demo applications in isolation using a matrix strategy, improving the CI pipeline's ability to catch regressions early in individual demo apps.
- Implements matrix builds for 4 demo apps (next-app, vite-project, adonisjs, react-router-app)
- Adds pnpm store and Turbo caching to optimize build performance
- Captures build logs as artifacts on failure for easier debugging
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: echo "STORE_PATH=$(pnpm store path)" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Restore pnpm cache | ||
| uses: actions/cache@v3 |
Copilot
AI
Nov 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actions/cache@v3 action is outdated. Since actions/upload-artifact@v4 is being used elsewhere in this workflow (line 66), it would be more consistent to use actions/cache@v4 here as well. Using the latest version provides better performance and compatibility with current GitHub Actions infrastructure.
| uses: actions/cache@v3 | |
| uses: actions/cache@v4 |
| CI: true | ||
| run: | | ||
| mkdir -p logs | ||
| pnpm turbo build --force --filter ./demo/${{ matrix.app }} 2>&1 | tee logs/build-${{ matrix.app }}.log |
Copilot
AI
Nov 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The --force flag forces Turbo to rebuild without using cache, which defeats the purpose of setting up Turbo caching in line 54-55. This will significantly slow down CI runs. Consider removing the --force flag to allow Turbo to use its cache for faster builds, or document why cache invalidation is necessary for these builds.
| pnpm turbo build --force --filter ./demo/${{ matrix.app }} 2>&1 | tee logs/build-${{ matrix.app }}.log | |
| pnpm turbo build --filter ./demo/${{ matrix.app }} 2>&1 | tee logs/build-${{ matrix.app }}.log |
chore(ci): add matrix workflow to build demo apps [skip i18n]
This PR introduces a GitHub Actions workflow that builds each demo app in isolation using a matrix:
Key improvements:
Context and rationale: Fixes #1355