change: [UIE-9860] - Change the default selection of network interface type to linode interface in Linode create flow

[grevanak-akamai]

Description 📝

Change the default selection of network interface type from legacy 'configuration profile' to 'linode interface' in Linode create flow.

Changes 🔄

• Changed default value of interface generation type to 'linode' in getDefaultInterfaceGenerationFromAccountSetting utility function

Scope 🚢

Upon production release, changes in this PR will be visible to:

• All customers
• Some customers (e.g. in Beta or Limited Availability)
• No customers / Not applicable

Target release date 🗓️

NA

Preview 📷

Before	After

How to test 🧪

Prerequisites

• In account settings, ensure the network interface type for new linodes is "config profile but allow Linode interface"

Verification steps

• Network interface type in Linode create flow should be "Linode interfaces" by default.

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

• I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

• All tests and CI checks are passing
• TypeScript compilation succeeded without errors
• Code passes all linting rules

[linode-gh-bot]

Cloud Manager UI test results

🔺 7 failing tests on test run #4 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
7 Failing	863 Passing	11 Skipped	54m 31s

Details

Failing Tests
	Spec	Test
❌	create-linode-with-vpc.spec.ts	Cloud Manager Cypress Tests→Create Linode with VPCs (Linode Interfaces) » can assign existing VPCs during Linode Create flow (legacy)
❌	create-linode-with-vpc.spec.ts	Cloud Manager Cypress Tests→Create Linode with VPCs (Linode Interfaces) » can assign new VPCs during Linode Create flow (legacy)
❌	create-linode-with-firewall.spec.ts	Cloud Manager Cypress Tests→Create Linode with Firewall (Linode Interfaces) » can assign existing Firewall during Linode Create flow (legacy)
❌	create-linode-with-firewall.spec.ts	Cloud Manager Cypress Tests→Create Linode with Firewall (Linode Interfaces) » can assign new Firewall during Linode Create flow (legacy)
❌	create-linode-with-firewall.spec.ts	Cloud Manager Cypress Tests→Create Linode with Firewall (Linode Interfaces) » can generate and assign a compliant Firewall during Linode Create flow (legacy)
❌	create-linode-with-vlan.spec.ts	Cloud Manager Cypress Tests→Create Linode with VLANs (Linode Interfaces) » can assign existing VLANs during Linode create flow (legacy)
❌	create-linode-with-vlan.spec.ts	Cloud Manager Cypress Tests→Create Linode with VLANs (Linode Interfaces) » can assign new VLANs during Linode create flow (legacy)

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/create-linode-with-vpc.spec.ts,cypress/e2e/core/linodes/create-linode-with-firewall.spec.ts,cypress/e2e/core/linodes/create-linode-with-vlan.spec.ts"

[coliu-akamai]

heads up - I haven't run the cypress tests locally, but they look related since they have to do with the Linode Create tests

oh whoops my other comment didn't get submitted 😅

[coliu-akamai]

would it make more sense to instead remove legacy_config_default_but_linode_allowed as an option in the Account Settings page?

reading through the aha, I also like Daniel's suggestion for a single setting. Although I understand legacy_config_default_but_linode_allowed is more for the API and doesn't have to correspond to CM's preselected default value, I feel like the current mismatch could lead to confusion + we'd have to be careful in our explanation