WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@mattf
Copy link
Collaborator

@mattf mattf commented Dec 4, 2025

What does this PR do?

This change removes the unused list_models method and ListModelsResponse class from the Llama Stack API.

Key changes:

  • Removed ListModelsResponse from models.py and init.py
  • Removed list_models method from the Models protocol
  • Updated ModelsRoutingTable to remove the list_models implementation
  • Modified validate_vector_stores_config in stack.py to use openai_list_models
  • Updated all unit tests to use the new OpenAI-compatible API
  • Removed unused imports across the codebase

This change removes the unused `list_models` method and `ListModelsResponse` class from the Llama Stack API.

Key changes:
- Removed `ListModelsResponse` from models.py and __init__.py
- Removed `list_models` method from the `Models` protocol
- Updated `ModelsRoutingTable` to remove the `list_models` implementation
- Modified `validate_vector_stores_config` in stack.py to use `openai_list_models`
- Updated all unit tests to use the new OpenAI-compatible API
- Removed unused imports across the codebase
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 4, 2025
@mattf
Copy link
Collaborator Author

mattf commented Dec 4, 2025

@derekhiggins ptal, this touches some of the model handling code

@franciscojavierarceo ptal, this changes how vector stores creation find models

if you like this, i'll get it passed the telemetry tests

Copy link
Collaborator

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

this looks like the right direction to me

@derekhiggins
Copy link
Contributor

Looks reasonable to me

I hit an errror running it locally, not sure why CI misses it

  File "/home/derekh/workarea/llama-stack/src/llama_stack/core/stack.py", line 138, in register_resources
    f"{rsrc.capitalize()}: {obj.identifier} served by {obj.provider_id}",
                            ^^^^^^^^^^^^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants