Add support for Windows x64 platforms #277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ozamir_nuvoton <[email protected]>
| #else // not _WIN32 | ||
| // Check for standard definition of fixed-width integer types | ||
| #ifndef UINT8_MAX | ||
| /* Fallback for old compilers which do not provide a standart <stdint.h> header |
Collaborator
There was a problem hiding this comment.
Suggested change
| /* Fallback for old compilers which do not provide a standart <stdint.h> header | |
| /* Fallback for old compilers which do not provide a standard <stdint.h> header |
| typedef unsigned int size_t; | ||
| #else // not _WIN32 | ||
| // Check for standard definition of fixed-width integer types | ||
| #ifndef UINT8_MAX |
Collaborator
There was a problem hiding this comment.
do we need to wrap this in a UINT8_MAX ifndef? Just because UINT8_MAX is not defined does not necessarily mean the following (e.g., uint8_t , uint16_t, uint32_t, uint64_t) are undefined does it?
Collaborator
There was a problem hiding this comment.
also above, you still have a ifdef _WIN32 clause. do you want that to be "_WIN32 or _WIN64"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed ate_api.h: updated macros to work correctly on both Win32 and x64 platforms.
Build.bazel: changed artifacts to windows_win32 and windows_x64.