fix(deployer): handle JSONC comments in tsconfig.json (#10952) #11040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `hasPaths()` function was using `JSON.parse()` to read tsconfig.json, which fails on JSONC comments. This caused path aliases like `@src/*` to not be resolved, leading to them being treated as npm scoped packages. Before (broken): ```js const config = JSON.parse(fs.readFileSync(tsConfigPath, 'utf8')); // throws on comments, catch returns false ``` After (fixed): ```js const content = fs.readFileSync(tsConfigPath, 'utf8'); const config = JSON.parse(stripJsonComments(content)); // now works with JSONC comments ``` Fixes #10942 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Bug Fixes** * Fixed parsing of TypeScript configuration files containing comments, ensuring path aliases (e.g., `@src/*`) are correctly recognized instead of being misclassified as npm scopes. * **Tests** * Added comprehensive test coverage for configuration file parsing and plugin integration. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> (cherry picked from commit 2a54120)
🦋 Changeset detectedLatest commit: 6bea68b The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
wardpeet
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #10952 to the 0.x branch
(cherry picked from commit 2a54120)