Make token refresher init itself lazily #5106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It needs a network connection to do the init, so this would fail if a client tried to do it at startup with no internet, causing the token to just never be refreshed. This just changes the API (compatibly) to do the init lazily. The promise is kept is retain backwards compat, it can be removed later.
dbkr
added a commit
to element-hq/element-web
that referenced
this pull request
Dec 11, 2025
This was a bit odd where the function to create a refresher sometimes created a refresher and sometimes just returned null, including if the init failed, in which case you would just end up with no token refresher. Pairs with matrix-org/matrix-js-sdk#5106 but doesn't depend on either way.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs a network connection to do the init, so this would fail if a client tried to do it at startup with no internet, causing the token to just never be refreshed.
This just changes the API (compatibly) to do the init lazily.
The promise is kept is retain backwards compat, it can be removed later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.