Start CallEventHandler and GroupCallEventHandler if isVoipWithNoMediaAllowed is set to true #5108
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Allowed is set to true. Signed-off-by: Alfred Jophy <[email protected]>
github-actions
bot
added
the
Z-Community-PR
florianduros
requested review from
a team and
robintown
and removed request for
a team
dbkr
reviewed
Dec 12, 2025
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
Leaving it to VoIP to works out if this is desired, although I find it confusing that you'd still start Call Event Handlers sometimes even if disableVoip was passed. It feels like we're re-using existing flags to do something else. This definitely feels like something I'd expect docs for, and most certainly tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start CallEventHandler and GroupCallEventHandler when
isVoipWithNoMediaAllowedis set to true. This lets you use the SDK on the server for managing calls.