WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@jplatte
Copy link
Collaborator

@jplatte jplatte commented Dec 11, 2025

  • Public API changes documented in changelogs (optional)

Signed-off-by: Jonas Platte

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 11, 2025

CodSpeed Performance Report

Merging #5950 will not alter performance

Comparing jplatte/sqlite2024 (f863b52) with main (2522a36)

Summary

✅ 50 untouched

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.51%. Comparing base (2522a36) to head (f863b52).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-sqlite/src/error.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5950   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         363      363           
  Lines      103432   103430    -2     
  Branches   103432   103430    -2     
=======================================
+ Hits        91548    91551    +3     
+ Misses       7531     7524    -7     
- Partials     4353     4355    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jplatte jplatte marked this pull request as ready for review December 11, 2025 12:24
@jplatte jplatte requested a review from a team as a code owner December 11, 2025 12:24
@jplatte jplatte requested review from poljar and removed request for a team December 11, 2025 12:24
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@poljar poljar merged commit ad58607 into main Dec 11, 2025
67 of 68 checks passed
@poljar poljar deleted the jplatte/sqlite2024 branch December 11, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants