-
Notifications
You must be signed in to change notification settings - Fork 23k
Editorial review: Document anchor-scope property #42227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Preview URLs
Flaws (22)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
(comment last updated: 2025-12-08 15:41:16) |
estelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, didn't realize this was in tech review... so sharing my few comments, but will wait til editorial to finish the review
| font-size: 1.8rem; | ||
| color: white; | ||
| text-shadow: 1px 1px 1px black; | ||
| background-color: blue; | ||
| width: fit-content; | ||
| padding: 3px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest hiding css that isn't lesson-related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit is all hidden.
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
andruud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
|
||
| #### Result | ||
|
|
||
| The examples renders like so: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"example renders"?
or
"examples render"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Fixed.
|
|
||
| The examples renders like so: | ||
|
|
||
| {{ EmbedLiveSample("basic_usage", "100%", "225") }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how MDN works, but naively I'd assume this embeds the exact same example as on line 133.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this should be "comparing-values". Fixed.
|
Thanks for the review, @andruud; I'll move this one on to the editorial review stage now. |
Description
Chrome 131 supports the
anchor-scopeproperty; see https://chromestatus.com/feature/5094192052436992. It is also supported in Safari 26, and behind a pref in Fx Nightly.This PR documents
anchor-scope.Motivation
Additional details
Related issues and pull requests
Fixes #39295