WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Update CMake requirements #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
colinbarry merged 5 commits into from
Aug 14, 2025
Merged

Update CMake requirements #86

colinbarry merged 5 commits into from
Aug 14, 2025

Conversation

@colinbarry
Copy link
Contributor

@colinbarry colinbarry commented Aug 13, 2025 •
edited
Loading

Update to support a newer version of CMake. Previously, building on Windows CI failed, due to requiring a CMake version that is no longer supported - compatibility with CMake < 3.5 has been removed since a few versions ago.

  • Update main project requirements from CMake 3.4 to 3.5.
  • Update gflags to the first commit which supports newer CMake versions (and update the CMakeLists to use the new name for the gflags static library).

@colinbarry colinbarry self-assigned this Aug 13, 2025
@colinbarry colinbarry force-pushed the feat/support-zoned-date-times branch from 629b98a to 1c7cb87 Compare August 13, 2025 15:10
@colinbarry colinbarry added the enhancement enhancement label Aug 13, 2025
@colinbarry colinbarry marked this pull request as draft August 13, 2025 15:11
@colinbarry colinbarry changed the title Support ZonedDateTime Update CMake requirements Aug 14, 2025
@colinbarry colinbarry added the Docs unnecessary Docs unnecessary label Aug 14, 2025
@colinbarry colinbarry requested a review from mattkjames7 August 14, 2025 08:20
@colinbarry colinbarry marked this pull request as ready for review August 14, 2025 08:25
@colinbarry colinbarry merged commit 829d46d into master Aug 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattkjames7 mattkjames7 mattkjames7 approved these changes

Assignees

@colinbarry colinbarry

Labels

Docs unnecessary Docs unnecessary enhancement enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colinbarry @mattkjames7