Fix: Do not embed (dirty) in the docker built version #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
FYI: I found the problem by pushing a tag on my personal repo and adding git status --short before the cargo build step in Dockerfile. It showed Dockerfile was deleted on the git status. Then I verified this fixed it by adding some logging to the build file and trying to build locally after deleting Dockerfile manually. Self tACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed all the docker builds have
(dirty)string in their versions.It's because Dockerfile's COPY . . doesn't copy Dockerfile because it's ignored by docker by default.
So git sees this as "you deleted Dockerfile but haven't committed it" and the status is dirty.