Implemented Shimmer effect on the Feed screen #629
Conversation
07jasjeet
left a comment
07jasjeet
left a comment
There was a problem hiding this comment.
Most of the stuff looks good, just a few changes.
| shimmerInstance: Shimmer, | ||
| uriHandler: UriHandler = LocalUriHandler.current | ||
| ) { | ||
| // Since, at most one drop down will be active at a time, then we only need to maintain one state variable. |
There was a problem hiding this comment.
Try to maintain existing comments. Here, we can get rid of this as code makes the intent clear anyways.
There was a problem hiding this comment.
I must have removed it by mistake , i'll be shaper next time about preserving existing comments 👍
| goToArtistPage = goToArtistPage | ||
| ) | ||
| if (inRefreshingState) { | ||
| items(4) { |
There was a problem hiding this comment.
Can we add more items here, such that we are able to fill up the whole screen? In order to fill the whole screen, you can measure the layout using subcompose layout and then use BoxWithConstraints (outside Lazy column) to get max available height.
There was a problem hiding this comment.
so should i do the same with the other tabs as well ??
2 participants
FIXES #616
This PR implements the shimmer effect for the loading state on the Feed Screen for each section (My Feed , Follow Listens , Similar Listens) and have synced it with the pull-to-refresh implementation also.
Screen Recording
Here is the Screen Recording for reference :-
Feed_Shimmer.mp4