ci: update deploy and test workflow for WAF deployment testing #790
Conversation
Harsh-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
nchandhi and
toherman-msft
as code owners
There was a problem hiding this comment.
Pull request overview
This pull request updates the CI/CD infrastructure to support WAF (Well-Architected Framework) deployment testing alongside regular deployments. The changes introduce deployment type selection based on odd/even days or manual workflow dispatch, migrate from direct az deployment commands to Azure Developer CLI (azd), and add support for specifying Azure AI Service location as a separate parameter.
Key changes include:
- Addition of
azureAiServiceLocationparameter to infrastructure configuration files - Migration to
azdCLI for deployments with automated environment management - Implementation of WAF deployment testing with temporary network access configuration
- Alternating deployment types (WAF/Non-WAF) based on calendar day for automated testing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| infra/main.parameters.json | Added azureAiServiceLocation parameter to specify Azure AI Service region |
| infra/main.waf.parameters.json | Added azureAiServiceLocation parameter for WAF deployments |
| .github/workflows/CAdeploy.yml | Major refactoring: added deployment type selection, migrated to azd CLI, added WAF-specific network access handling, simplified cleanup using azd down |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| azd env set AZURE_ENV_AI_DEPLOYMENTS_LOCATION="${{ env.AZURE_LOCATION }}" | ||
| azd env set AZURE_ENV_MODEL_CAPACITY="${{ env.GPT_MIN_CAPACITY }}" | ||
| azd env set AZURE_ENV_EMBEDDING_MODEL_CAPACITY="${{ env.TEXT_EMBEDDING_MIN_CAPACITY }}" | ||
| azd env set AZURE_ENV_IMAGETAG="${IMAGE_TAG}" |
There was a problem hiding this comment.
The parameter files reference AZURE_ENV_AI_SERVICE_LOCATION but this environment variable is never set. You should add a line to set this variable, likely to the same value as AZURE_LOCATION based on the parameter file configuration. Add: azd env set AZURE_ENV_AI_SERVICE_LOCATION="${{ env.AZURE_LOCATION }}"
| azd env set AZURE_ENV_IMAGETAG="${IMAGE_TAG}" | |
| azd env set AZURE_ENV_IMAGETAG="${IMAGE_TAG}" | |
| azd env set AZURE_ENV_AI_SERVICE_LOCATION="${{ env.AZURE_LOCATION }}" |
| EMAIL_BODY=$(cat <<EOF | ||
| { | ||
| "body": "<p>Dear Team,</p><p>We would like to inform you that the Build-your-own-copilot-Solution-Accelerator(Client Advisior) Automation process has encountered an issue and has failed to complete successfully.</p><p><strong>Build URL:</strong> ${RUN_URL}<br> ${OUTPUT}</p><p>Please investigate the matter at your earliest convenience.</p><p>Best regards,<br>Your Automation Team</p>" | ||
| "body": "<p>Dear Team,</p><p>We would like to inform you that the Build-your-own-copilot-Solution-Accelerator(Client Advisior) - ${{ env.DEPLOYMENT_TYPE }} Automation process has encountered an issue and has failed to complete successfully.</p><p><strong>Build URL:</strong> ${RUN_URL}<br> ${OUTPUT}</p><p>Please investigate the matter at your earliest convenience.</p><p>Best regards,<br>Your Automation Team</p>" |
There was a problem hiding this comment.
Spelling error: "Advisior" should be "Advisor"
| "body": "<p>Dear Team,</p><p>We would like to inform you that the Build-your-own-copilot-Solution-Accelerator(Client Advisior) - ${{ env.DEPLOYMENT_TYPE }} Automation process has encountered an issue and has failed to complete successfully.</p><p><strong>Build URL:</strong> ${RUN_URL}<br> ${OUTPUT}</p><p>Please investigate the matter at your earliest convenience.</p><p>Best regards,<br>Your Automation Team</p>" | |
| "body": "<p>Dear Team,</p><p>We would like to inform you that the Build-your-own-copilot-Solution-Accelerator(Client Advisor) - ${{ env.DEPLOYMENT_TYPE }} Automation process has encountered an issue and has failed to complete successfully.</p><p><strong>Build URL:</strong> ${RUN_URL}<br> ${OUTPUT}</p><p>Please investigate the matter at your earliest convenience.</p><p>Best regards,<br>Your Automation Team</p>" |
| "azureAiServiceLocation": { | ||
| "value": "${AZURE_ENV_AI_SERVICE_LOCATION}" | ||
| }, |
There was a problem hiding this comment.
The new parameter AZURE_ENV_AI_SERVICE_LOCATION is not documented in the CustomizingAzdParameters.md file. This parameter should be added to the parameters table with information about its purpose (location for AI Foundry deployment) and the allowed values based on the bicep constraints (australiaeast, eastus, eastus2, francecentral, japaneast, swedencentral, uksouth, westus, westus3).
Purpose
This pull request introduces a new parameter to both the main and WAF infrastructure parameter files to support specifying the Azure AI Service location. This change helps ensure deployments can target the correct regional AI resources.
Infrastructure configuration updates:
azureAiServiceLocationparameter toinfra/main.parameters.jsonto allow configuration of the Azure AI Service region.azureAiServiceLocationparameter toinfra/main.waf.parameters.jsonfor consistent regional AI Service configuration in WAF deployments.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information