Updated comment to trig functions to mention radians #2825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change in memory usage detected by benchmark. Memory Report for 1b10926
|
ScottCarda-MS
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed elsewhere,
there's only one way to specify argument for trig functions and we already use it. We provide PI() so it should be convenient. Having said that, degrees are taught in school, so the only reason we may consider doing something about it is to facilitate education somehow.
I probably mentioned this before, but "radians" are just numbers. They are ratios of two lengths. So, no matter the unit for the length, the ration is just a number.
As for the issue, I don't see much harm in mentioning that we are using radians. They are part of the International System of Units after all. Although as a "derived unit". Degrees don't have the honor. They are just "acceptable". (https://www.bipm.org/documents/20126/41483022/SI-Brochure-9.pdf, page 145)
Resolves #2773