[heft-rspack-plugin] implement DeferredWatchFileSystem
#5457
+289
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmiddha
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton,
octogonz and
patmill
as code owners
dmichon-msft
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Copy the
DeferredWatchFileSystemimplementation forheft-webpack5-pluginand make it work withheft-rspack-pluginFixes #5452
Details
An issue was reported where the rspack plugin gets stuck with
Cancelling incremental build...message when an incremental build is running. This reproduces consistently when a change is made while a compilation is running.This PR adds the
DeferredWatchFileSystemfromheft-webpack5-pluginwhich mitigates the issue.This PR also has a change in
heft-webpack5-pluginto update a logging message which incorrectly says "Rspack" instead of "Webpack"How it was tested
Tested that
heft build-watchandheft build-watch --servework when files are changed while a compilation is running.Impacted documentation