Fix White flash issue in window.ts (#132339) #281765
Closed
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Author
|
@bpasero @deepak1556 @hediet no updates as of now? |
Collaborator
|
As mentioned before we are just trading one bug for another #245208 (comment) With regards to #245208 (comment) the |
Author
|
@deepak1556 but this does solve the major concern of having the white flash which a much more bigger issue right now than a ultimate fix. Until we have a proper fix, this mitigation is better for temporary fix. Don't you think it will save many from white flashes everytime? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132339
I have to reopen this PR as the fix was marked incorrectly by #249241 (comment)
I modified this line, so the white flash won't occur when opening VS Code in maximized window happening in Windows OS.
Previous code: Line 140
Updated code: Line 142
Issue
Before
428930115-7acb36cc-0bed-4812-9846-beb498fd2fd8.mp4
After
Issue-Fix
428930203-3eb5e483-2678-42bf-9342-052cabbb2731.mp4
I know that it isn't a proper one-shot fix! But this mitigate the Eye Burning White Flash every-time someone opens it on Windows OS!