WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@qinsoon
Copy link
Member

@qinsoon qinsoon commented Mar 13, 2024

Currently all the tracing in a nursery GC is done in GenNurseryProcessEdges, including objects reachable from root, and objects reachable from mod buf. This PR uses seperate work packet types for objects that are from mod buf. This helps us understand the nursery GC time better.

@wks
Copy link
Collaborator

wks commented Apr 1, 2024

Alternatively, we can add a field in struct GenNurseryProcessEdges to identify their sources. For example,

pub struct GenNurseryProcessEdges<VM: VMBinding, P: GenerationalPlanExt<VM> + PlanTraceObject<VM>> {
    plan: &'static P,
    base: ProcessEdgesBase<VM>,
    source: PacketSource,
}

enum PacketSource {
    Root,
    ModBuf,
    RegionModBuf,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants