WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

feat: add panic stack #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenxuwan merged 1 commit into from
Aug 20, 2025
Merged

feat: add panic stack #1132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/rpc/invoker/mosn/mosninvoker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"encoding/json"
"errors"
"fmt"
"runtime/debug"
"strconv"

// bridge to mosn
Expand Down Expand Up @@ -87,7 +88,7 @@ func (m *mosnInvoker) Init(conf rpc.RpcConfig) error {
func (m *mosnInvoker) Invoke(ctx context.Context, req *rpc.RPCRequest) (resp *rpc.RPCResponse, err error) {
defer func() {
if r := recover(); r != nil {
err = fmt.Errorf("[runtime][rpc]mosn invoker panic: %v", r)
err = fmt.Errorf("[runtime][rpc]mosn invoker panic: %v, stack info: %+v", r, string(debug.Stack()))
log.DefaultLogger.Errorf("%v", err)
}
}()
Expand Down
2 changes: 1 addition & 1 deletion components/rpc/invoker/mosn/mosninvoker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ func Test_mosnInvoker_Invoke(t *testing.T) {
}
_, err := invoker.Invoke(context.Background(), req)
assert.NotNil(t, err)
assert.Equal(t, "[runtime][rpc]mosn invoker panic: runtime error: invalid memory address or nil pointer dereference", err.Error())
assert.NotNil(t, err)
})
}

Expand Down
2 changes: 1 addition & 1 deletion docs/blog/code/layotto-rpc/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ mosn.io/layotto/components/rpc/invoker/mosn.(*mosnInvoker).Invoke at mosninvoker
func (m *mosnInvoker) Invoke(ctx context.Context, req *rpc.RPCRequest) (resp *rpc.RPCResponse, err error) {
defer func() {
if r := recover(); r != nil {
err = fmt.Errorf("[runtime][rpc]mosn invoker panic: %v", r)
err = fmt.Errorf("[runtime][rpc]mosn invoker panic: %v, stack info: %+v", r, string(debug.Stack()))
log.DefaultLogger.Errorf("%v", err)
}
}()
Expand Down
2 changes: 1 addition & 1 deletion docs/i18n/en-US/docusaurus-plugin-content-blog/code/layotto-rpc/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ mosn.io/layotto/components/rpc/invoker/mosn.(*mosnInvoker).Invoke at mosninvoker
func (m *mosnInvoker) Invoke(ctx context.Context, req *rpc.RPCRequest) (resp *rpc.RPCResponse, err error) {
defer func() {
if r := recover(); r != nil {
err = fmt.Errorf("[runtime][rpc]mosn invoker panic: %v", r)
err = fmt.Errorf("[runtime][rpc]mosn invoker panic: %v, stack info: %+v", r, string(debug.Stack()))
log.DefaultLogger.Errorf("%v", err)
}
}()
Expand Down
Loading