MPP-4497: update VPN bundle page layout and text #6092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpremamozilla
force-pushed
the
MPP-4497-update-relay-vpn-onboarding-page
branch
2 times, most recently
from
c642c87 to
937fd91
Compare
jwhitlock
approved these changes
Dec 1, 2025
Member
jwhitlock
left a comment
jwhitlock
left a comment
There was a problem hiding this comment.
Thanks @vpremamozilla! One question, maybe vpn-relay-go-relay-body-3 should bevpn-relay-go-relay-body-2
frontend/pendingTranslations.ftl
Outdated
| phone-onboarding-step1-button-cta-2 = Sign up | ||
| phone-onboarding-step1-learn-more = Learn more | ||
| vpn-relay-go-relay-body-2 = Keep your identity private |
Member
There was a problem hiding this comment.
Is vpn-relay-go-relay-body-2 used? I can't find it in the code.
Collaborator
Author
There was a problem hiding this comment.
good callout, i will remove
vpremamozilla
force-pushed
the
MPP-4497-update-relay-vpn-onboarding-page
branch
from
937fd91 to
acd3805
Compare
Collaborator
Author
unfortunately, the l10n PR was already merged so had to use 3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPP-4497
How to test
navigate to http://localhost:3000/vpn-relay-welcome/
check AC
NOTE: design has been verified by Tony
Screenshot (if applicable)
Checklist (Definition of Done)
/frontend/src/styles/colors.scss).