-
-
Notifications
You must be signed in to change notification settings - Fork 237
FEATURE: Enable migration Version20251005080230 which adjusts EEL in Fusion code to the new Neos 9 API
#5642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n Fusion code to the new Neos 9 API The command `neos9preparation:preadjustfusion` from Neos 8.4 was removed as `flow:core:migrate Neos.Demo --version 20251005080230` is now its successor
This is not part of the 8.4 migrations This reverts commit 60b7a58.
6430f8c to
fdb8764
Compare
…igration the YamlWithComments which allowed this is a funny beast but a lot of complexity just comments https://github.com/neos/rector/blob/efbff0d060f9cf115c7c99fdcefeb07c488a3273/src/Core/YamlProcessing/YamlWithComments.php#L7 In fusion we add warning comments instead to the beginning of the file which should also server well. In the future we want to evaluate if we can migrate yaml by keeping the current comments - if we manage that we can also probably inject some ourselves cleanly without hacks.
|
Denny and me agreed that we want to add these 3 migration files retroactively to Neos 9 via patch release as even running the core migrations on an existing running 9.0 project should not do any harm. And migrations are run explicitly under supervision of a developer:)
(*) it could happen that a false positive todo comment is written to fusion files but thats it :) |
…ionsFromRector FEATURE: Add yaml Flow core Neos 9 migrations (previously in rector)
…igrationForNeos9Update
Adjustment after the upmerge of #5638 for 9.0
This is a step of the process to remove the fusion migration task from
neos/rector. People who already updated via theneos/rectormigrations or already are on Neos 9.0 will find this migration obsolete - though we cannot recognise that and thus the migration will be run on the package never-the-less if executed via./flow flow:core:migrateTo especially prevent these new fusion migrations from being run they have to be manually excluded before running
flow:core:migrateby modifying the composer.json to include:{ "extra": { "applied-flow-migrations": [ // ... "Neos.Neos-20251005080230", "Neos.Fusion-20251006080506" ] } }Users already on 9.0 might need to exclude the fusion migrations when updating to this patch as there could be false positive detections when using
${item.label}or${item.identfier}in Fusion which is found by this migration as possible unsafe. The migration recognises that the variable item could be node which would require manual adjustments and thus the migration adds a todo comment to the file. These todo comments then might be totally obsolete for people already on a working 9.0.Upgrade instructions
Review instructions
The command
neos9preparation:preadjustfusionfrom Neos 8.4 was removed asflow:core:migrate Neos.Demo --version 20251005080230is now its successorChecklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions