WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@NAM-MAN
Copy link

@NAM-MAN NAM-MAN commented Nov 23, 2019

see #576

Despite the fact that it can be commented that FileObject can be obtained in this line, it was not a valid code, so it was modified.
@coveralls
Copy link

coveralls commented Nov 23, 2019

Coverage Status

Coverage increased (+0.06%) to 96.892% when pulling 41cfefa on NAM-MAN:fix_upload_file_example_broken into 9232e1a on noirbizarre:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 96.782% when pulling c262676 on NAM-MAN:fix_upload_file_example_broken into 9232e1a on noirbizarre:master.

@andreixk
Copy link

@NAM-MAN can you add corresponding unit tests to ensure the changes are covered?

@NAM-MAN
Copy link
Author

NAM-MAN commented Nov 25, 2019

@andreixk
Looking at unittest changed my mind.
In this example, just parse like unittest.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants