Handle temperature values as floats in DM5 files #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nradov
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within SDE files exported from DM5, the temperature values are, for some unknown reason, saved as floating point numbers. As an example, if the recorded temperature was 28°C, the value would be saved as 27.99999 which causes the SDE to FIT process to fail.
This PR changes the evaluation of the temperature value to allow a floating point number. I tested with 18 dives exported from DM5 without issue. I also manually changed some of the temperature float values in the DM5 to integers (so as to mimic DM3 exports) and it worked as expected.