WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

fix:s3 handler ,cat function decode exception #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dualc wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix:s3 handler ,cat function decode exception #821

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4903917
fix decode err
Aug 6, 2025
b979d54
Merge branch 'main' into fix-decode-err
willingc Nov 14, 2025
3a0b864
add unit test
Nov 21, 2025
6d05af3
Merge branch 'fix-decode-err' of github.com:dualc/papermill into fix-…
Nov 21, 2025
8127dae
Merge branch 'nteract:main' into fix-decode-err
dualc Nov 21, 2025
e382ce4
adjust test
Nov 21, 2025
ad3258f
Merge branch 'fix-decode-err' of github.com:dualc/papermill into fix-…
Nov 21, 2025
87fbbf1
adjust s3 test
Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions papermill/s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ def cat(
size = 0
bytes_read = 0
err = None
undecoded = ''
undecoded = b''
if key:
# try to read the file multiple times
for i in range(100):
Expand Down Expand Up @@ -317,8 +317,8 @@ def cat(

if encoding and not raw:
try:
decoded = undecoded + s.decode(encoding)
undecoded = ''
decoded = (undecoded + s).decode(encoding)
undecoded = b''
yield decoded
except UnicodeDecodeError:
undecoded += s
Expand Down