WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@willingc
Copy link
Member

@willingc willingc commented Nov 12, 2025

What does this PR do?

  • Drop 3.8 and 3.9
  • Add 3.13 and 3.14
  • Relax threshold for codecov on project in addition to existing patch
  • Clean up packaging settings
  • Modernize doc build
  • Update tox settings
  • Skip failing tests and open issues to address

Related #819, #829, #830

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.99%. Comparing base (cb2eb37) to head (fd4132e).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   91.54%   90.99%   -0.56%     
==========================================
  Files          17       17              
  Lines        1621     1632      +11     
==========================================
+ Hits         1484     1485       +1     
- Misses        137      147      +10     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf60648...fd4132e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@willingc
Copy link
Member Author

@rgbkrk @winniehell I'm going to iterate and clean up this a bit more and pull in the fixes that Kyle just merged. Thanks for the help moving this forward. Planning to drop EOL python and add 3.13 and 3.14. Will ping you when ready for review.

@willingc willingc changed the title Fix for local doc build Update supported python versions and bring CI back to green Nov 12, 2025
@rgbkrk
Copy link
Member

rgbkrk commented Nov 12, 2025

I went ahead and merged in #826, let me know if that conflicts with your work or if this is an easy rebase.

@rgbkrk
Copy link
Member

rgbkrk commented Nov 12, 2025

@rgbkrk @winniehell I'm going to iterate and clean up this a bit more and pull in the fixes that Kyle just merged. Thanks for the help moving this forward. Planning to drop EOL python and add 3.13 and 3.14. Will ping you when ready for review.

Oops, I see your comment now after I wrote mine. Apologies moving quick on that one.

@willingc
Copy link
Member Author

No worries. I debated merging the other PR this morning and fell into the rabbit hole here.

@willingc
Copy link
Member Author

willingc commented Nov 12, 2025

TODO

@willingc willingc requested a review from rgbkrk November 13, 2025 01:51
@willingc
Copy link
Member Author

@rgbkrk If you have time to do a quick review, this should give us a more reliable CI to get some of the other PRs landed. Thanks.

@rgbkrk rgbkrk merged commit 2be801d into nteract:main Nov 13, 2025
12 checks passed
@rgbkrk
Copy link
Member

rgbkrk commented Nov 13, 2025

Awesome, thank you.

@willingc willingc deleted the doc-build branch November 13, 2025 05:52
@winniehell
Copy link
Contributor

looks good, thank you for the cleanup! 🙂

'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
'Programming Language :: Python :: 3.12',
'Programming Language :: Python :: 3.13',
Copy link
Contributor

@winniehell winniehell Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to have a new release that officially supports 3.13 out there. please ignore my comment if you have one planned already. 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily classifiers are just metadata and the package can be installed on later versions without this. :D

I'm sure we'll get a new version out soon now that we've cleared through much of this backlog of PRs. See any more you'd like to target before a release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing in particular - thank you for digging through the pile! ❤️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI #844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants