-
Notifications
You must be signed in to change notification settings - Fork 443
Update supported python versions and bring CI back to green #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
==========================================
- Coverage 91.54% 90.99% -0.56%
==========================================
Files 17 17
Lines 1621 1632 +11
==========================================
+ Hits 1484 1485 +1
- Misses 137 147 +10 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@rgbkrk @winniehell I'm going to iterate and clean up this a bit more and pull in the fixes that Kyle just merged. Thanks for the help moving this forward. Planning to drop EOL python and add 3.13 and 3.14. Will ping you when ready for review. |
|
I went ahead and merged in #826, let me know if that conflicts with your work or if this is an easy rebase. |
Oops, I see your comment now after I wrote mine. Apologies moving quick on that one. |
|
No worries. I debated merging the other PR this morning and fell into the rabbit hole here. |
|
TODO
|
|
@rgbkrk If you have time to do a quick review, this should give us a more reliable CI to get some of the other PRs landed. Thanks. |
|
Awesome, thank you. |
|
looks good, thank you for the cleanup! 🙂 |
| 'Programming Language :: Python :: 3.10', | ||
| 'Programming Language :: Python :: 3.11', | ||
| 'Programming Language :: Python :: 3.12', | ||
| 'Programming Language :: Python :: 3.13', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to have a new release that officially supports 3.13 out there. please ignore my comment if you have one planned already. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Luckily classifiers are just metadata and the package can be installed on later versions without this. :D
I'm sure we'll get a new version out soon now that we've cleared through much of this backlog of PRs. See any more you'd like to target before a release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing in particular - thank you for digging through the pile! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI #844
What does this PR do?
Related #819, #829, #830