fix(runtime-utils): reject promise on error render + mount helpers #1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
yamachi4416
force-pushed
the
fix/handleThrowInComponent
branch
from
a695025 to
6c0c135
Compare
yamachi4416
force-pushed
the
fix/handleThrowInComponent
branch
from
6c0c135 to
3b9eeab
Compare
danielroe
approved these changes
Dec 7, 2025
Contributor
Author
|
Thank you for the review. I noticed that I missed adding a cleanup step in the render test I previously added, so I made an additional commit to fix this. I would appreciate it if you could review this one as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #875, resolves #1037
❓ Type of change
📚 Description
reproduction: https://stackblitz.com/edit/github-jk1bg9-rlxpkwz2?file=package.json,app.nuxt.test.ts