Adopt existing sub when packagemanifest not found #312
Conversation
Previously, if the pacakagemanifest was missing, perhaps due to the operator no longer being available in the catalog, the operator policy would be marked as invalid, and not report on the potentially helpful status of the subscription. Now the existing subscription can be used for the default values, and a more helpful status can be reported. Refs: - https://issues.redhat.com/browse/ACM-14617 Signed-off-by: Justin Kulikauskas <[email protected]>
JustinKuli
force-pushed
the
14617-adopt-more-subscriptions
branch
from
729db68 to
56dc174
Compare
| "%wthe subscription defaults could not be determined because the PackageManifest was not found", | ||
| ErrPackageManifest, | ||
| ) | ||
| if !r.usingExistingSubIfFound(policy, subscription) { |
There was a problem hiding this comment.
Do we have any status change for usingExistingSubIfFound? such as message
There was a problem hiding this comment.
It doesn't make a special status directly, it just allows the policy to be considered valid so that the status of the subscription can be updated (an invalid policy doesn't update the other conditions). The subscription status will have more information in some cases, for example explaining that the operator is not available in a catalog.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f2a42b5
into
open-cluster-management-io:main
2 participants
Previously, if the pacakagemanifest was missing, perhaps due to the operator no longer being available in the catalog, the operator policy would be marked as invalid, and not report on the potentially helpful status of the subscription. Now the existing subscription can be used for the default values, and a more helpful status can be reported.
Refs: