fix(git): support staged-only ghost commits and fix seatbelt test #8421
+41
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a 'staged_only' flag to CreateGhostCommitOptions. When enabled, it creates a ghost commit reflecting only the files currently staged in the git index, rather than all worktree changes. This addresses Issue openai#8404 where reviews were incorrectly including unstaged changes. Also includes a fix for a flaky seatbelt test in codex-core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8404
Description
This PR addresses Issue #8404 where code reviews incorrectly included unstaged working directory changes.
Changes
staged_onlyoption toCreateGhostCommitOptionsinghost_commits.rs.create_ghost_commit_with_reportto supportstaged_only:codex-core/src/seatbelt.rsrelated to bash output assertions.Verification
codex-git.