Refresh on models etag mismatch #8491
Conversation
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
aibrahim-oai
changed the title
|
@codex fix this |
| let _ = tx_event.send(Ok(ResponseEvent::RateLimits(snapshot))).await; | ||
| } | ||
| if let Some(etag) = models_etag { | ||
| let _ = tx_event.send(Ok(ResponseEvent::ModelsEtag(etag))).await; |
There was a problem hiding this comment.
bit annoying to have to push everything through events but that's how it is.
|
|
||
| /// Fetch the latest remote models, using the on-disk cache when still fresh. | ||
| pub async fn refresh_available_models(&self, config: &Config) -> CoreResult<()> { | ||
| pub async fn attempt_refresh_available_models(&self, config: &Config) -> CoreResult<()> { |
There was a problem hiding this comment.
can we keep one method? the difference is very subtle. Maybe add a "force" parameter?
There was a problem hiding this comment.
or pass etag as the parameter
There was a problem hiding this comment.
I feel it's cleaner this way though
There was a problem hiding this comment.
there are 3 different public refresh methods with subtly different semantics.
There was a problem hiding this comment.
at least name them better
refresh_if_new_etag
refresh_no_cache
refresh
or something similar.
There was a problem hiding this comment.
makes sense. will do that
| } | ||
|
|
||
| async fn get_etag(&self) -> Option<String> { | ||
| self.etag.read().await.clone() |
There was a problem hiding this comment.
It's not great that etag and models are not updated atomically.
There was a problem hiding this comment.
Only one method updates them though
There was a problem hiding this comment.
yes, but one value can be updated while the other isn't
There was a problem hiding this comment.
ok will see what I can change
| .url | ||
| .query_pairs() | ||
| .any(|(k, _)| k == "client_version"), | ||
| "expected /models refresh to include client_version query param" |
There was a problem hiding this comment.
Reminder to decide on how we are sending client_version consistently across endpoints.
|
Summary
Testing
|
ModelsManagertoModelFamilyso we don't mutate it mid-turn