fix(core): batch record parallel tool outputs to prevent partial history state #8509
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When processing parallel tool calls, drain_in_flight was recording output items one by one as they completed. This created a race condition where the conversation history could be in an inconsistent state (containing a tool call without its corresponding output) if inspected by a background task (like auto-compact or seatbelt) during the draining process. This resulted in "tool_call_id missing response" errors (GitHub Issue #8479).
Solution
Modified drain_in_flight in core/src/codex.rs to:
Vec.Validation
cargo check -p codex-corepassed.cargo clippy -p codex-corepassed.cargo test -p codex-corepassed.