feat(PriceTags): replace barcode with similar one if invalid #1723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
reviewed
Oct 4, 2025
| productPriceForm.similar_barcodes = label.similar_barcodes | ||
| // if there is a similar barcode, it's probably better than the guessed one if it's invalid | ||
| if (!barcode_utils.isBarcodeValid(productPriceForm.product_code)) { | ||
| productPriceForm.product_code = label.similar_barcodes[0].barcode |
Member
There was a problem hiding this comment.
what about giving the user the choice ? for instance:
- replacing the "invalid" product section with a message/banner
- having the "Find the product" display the whole (or a subset) of the similar_barcodes list ?
Member
There was a problem hiding this comment.
ah kinda like #1724 yeah ^^ + we "force" the user to go through the BarcodeScannerDialog, instead of validating a very-likely-wrong product
Collaborator
Author
There was a problem hiding this comment.
Yeah, I was thinking the same, so I implemented both options to choose from :D
Collaborator
Author
|
Will not merge, see #1724 for a better approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Note: this could also be done in the backend ?