Make PHPUnit fail on deprecation errors #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
You can test this by commenting out any class property and running the unit tests in php8.3+ to see the failure because dynamic class properties were deprecated |
sanmai
approved these changes
Oct 15, 2025
Member
sanmai
left a comment
sanmai
left a comment
There was a problem hiding this comment.
Tested, works.
error_reporting=-1makes PHP report deprecationsconvertDeprecationsToExceptionsmakes PHPUnit convert them to errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the PHPUnit to show Deprecation warnings and convert them to exceptions. This may not be the desired behavior, but it does enable earlier detection and correction of obsolete code in new versions of php.
Prompted by the missing
offsetclass property fixed in #49