Preserve already resolved types after scope re-creation #4677
+38
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Dec 28, 2025
src/Analyser/MutatingScope.php
Outdated
Comment on lines
4417
to
4418
| foreach($preservedTypes as $exprStringToInvalidate => $resolvedType) { | ||
| foreach ($expressionTypes as $exprString => $exprTypeHolder) { |
Contributor
Author
There was a problem hiding this comment.
we cannot use similar logic as in invalidateExpression because we don't know the Expr which $this->resolvedTypes was resolved with
Member
There was a problem hiding this comment.
I have a commit that puts ExpressionTypeHolder into resolvedTypes, do you want it?
Contributor
Author
There was a problem hiding this comment.
Might help. Sure why not :-).
Will be afk for a few hours now
Member
There was a problem hiding this comment.
I pushed it to 2.1.x. If it doesn't help you in the end, or if this PR does not lead to performance improvements, I'll revert it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements the idea described in #4648 (comment)
requires #4676