WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Update plips.md: be more precise about mentioning teams to submit a PLIP #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevepiercy merged 5 commits into from
Dec 18, 2025
Merged

Update plips.md: be more precise about mentioning teams to submit a PLIP #1972

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eeb03bc
Update plips.md: be more precise about mentioning teams to submit a PLIP
tisto Sep 17, 2025
c035eda
Apply suggestions from code review
stevepiercy Dec 1, 2025
fcf725d
Merge branch '6.0' into tisto-patch-1
stevepiercy Dec 16, 2025
4eef7b8
Update docs/contributing/core/plips.md
stevepiercy Dec 18, 2025
21f29e3
Merge branch '6.0' into tisto-patch-1
stevepiercy Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion docs/contributing/core/plips.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,19 @@ You may revise your PLIP based on feedback.
If you need help at any point in this process, you can either `@` the team or personally contact a member of the designated team.


(team-approves-proposal-label)=

## Team approves proposal

After incorporating feedback to your proposal, you can request a final review and approval for inclusion in Plone.
Every PLIP must be approved by the designated team.

You can do this by mentioning one of the appropriate {ref}`designated-teams-label`, with `@plone/framework-team` as the default if you're not certain.

Every PLIP must be approved by the designated team for work to be merged.

Although work may be started at any time, the PLIP may be revised many times or even rejected.
Set expectations accordingly before starting work on the PLIP.
In general, it's a good idea to wait for approval of the PLIP before starting work, but there are exceptions, such as creating a proof of concept to demonstrate what the PLIP would be designed to do, or you might need it for your own project anyway.


## Implement your PLIP
Expand Down