WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

ci!: drop Node 14/16 support #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gemy26 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ci!: drop Node 14/16 support #761

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c1005fc
ci!: drop Node 14/16 support
gemy26 Sep 9, 2025
5542e9a
fix: update engines to >=18.18.0 and CI
gemy26 Sep 9, 2025
23639ad
fix: update pnpm to 8.15.6 for CI compatibility
gemy26 Sep 9, 2025
0c6c9da
chore: trigger bot re-review
gemy26 Sep 9, 2025
cd523ea
Merge branch 'main' into drop-node14-16
gemy26 Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ jobs:
eslint:
- 9
- 8
include:
- node: 16
eslint: 8
- node: 14
eslint: 8
# include:
# - node: 16
# eslint: 8
# - node: 14
# eslint: 8

steps:
- name: Checkout Repo
Expand All @@ -53,8 +53,8 @@ jobs:
- name: Test
run: pnpm mocha

- name: Perf
# Skip on node 14, as eslint-plugin-n contains syntax that doesn't work
# with node 14
if: ${{ matrix.node != 14 }}
run: TIMING=1 pnpm lint
# - name: Perf
# # Skip on node 14, as eslint-plugin-n contains syntax that doesn't work
# # with node 14
# if: ${{ matrix.node != 14 }}
# run: TIMING=1 pnpm lint
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"license": "MIT",
"packageManager": "[email protected]",
"engines": {
"node": "^14.18.0 || >=16.0.0"
"node": ">=18.0.0"
},
"main": "eslint-plugin-prettier.js",
"types": "eslint-plugin-prettier.d.ts",
Expand Down