feat: add SetBody* methods for body handling
#496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dwi Siswanto <[email protected]>
When sending POST requests with a non-empty body that trigger 307/308 redirects, the redirects fail because the underlying `http.Request.GetBody` is nil by default. This patch populates `GetBody` using the existing reusable body reader, allowing the `net/http` client to rewind and replay the body. Fixes #493. Signed-off-by: Dwi Siswanto <[email protected]>
Signed-off-by: Dwi Siswanto <[email protected]>
This commit introduces `SetBody*` methods to the `Request` struct. These methods provide a consistent and safe way to set request bodies, ensuring that `GetBody` is correctly populated for retries and redirects (307/308). Changes: * `SetBodyReader`: Low-level setter for pre-existing reusable readers. * `SetBody`: Sets body from bytes, creating a fresh reusable reader for each attempt. * `SetBodyString`: Wrapper around SetBody for strings. * `SetBodyStream`: Consumes an `io.Reader` immediately into a reusable reader, handling `io.Closer` and `ContentLength` logic. * Updated `TestRedirectPOST*` tests to verify the new methods. This addresses issues where retries or redirects would fail due to a missing or non-reusable body. Signed-off-by: Dwi Siswanto <[email protected]>
Mzack9999
approved these changes
Dec 6, 2025
Mzack9999
deleted the
dwisiswant0/feat/add-SetBody-methods-for-body-handling
branch
Mzack9999
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces
SetBody*methods to theRequeststruct. These methods provide aconsistent and safe way to set request bodies,
ensuring that
GetBodyis correctly populated forretries and redirects (307/308).
Changes:
SetBodyReader: Low-level setter forpre-existing reusable readers.
SetBody: Sets body from bytes, creating afresh reusable reader for each attempt.
SetBodyString: Wrapper around SetBody forstrings.
SetBodyStream: Consumes anio.Readerimmediately into a reusable reader, handling
io.CloserandContentLengthlogic.TestRedirectPOST*tests to verify thenew methods.
This addresses issues where retries or redirects
would fail due to a missing or non-reusable body.
Closes #495
Fixes #493