Allow search() to request user/group attributes #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also prevent repr() from including the password.
Allow it to be a list or tuple.
tinvaan
reviewed
Nov 29, 2023
Comment on lines
+58
to
+59
| return "<CrowdServer('%s', '%s', '********')>" % \ | ||
| (self.crowd_url, self.app_name) |
There was a problem hiding this comment.
I think instead of a static string, we can maybe mask the password string matching it's length?
I know this gives away the length of the password but that could still be useful for users to know which password was used to configure the server.
Suggested change
| return "<CrowdServer('%s', '%s', '********')>" % \ | |
| (self.crowd_url, self.app_name) | |
| return "<CrowdServer('%s', '%s', '%s')>" % ( | |
| self.crowd_url, self.app_name, '*' * len(self.app_pass)) |
Optionally, we could add a private method that returns the raw password (probably out of scope for this PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also prevent repr() from including the password.