Fixed checking length for symbolic tensor + make Model2onnx agnostic to the type of model #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not limit it to .h5 models)
Owner
|
Hmm, everything look great, except that you removed try except, I am not sure if I am happy with this part |
Contributor
Author
|
The problem with this try/except is that it just hides the problem, instead of failing and having the user handle this exception and decide what to do, it just prints the exception and continues. If something goes wrong - it should be handled by the user. |
Owner
|
sounds logic, I'll check it, I planned to refactor this package to be compatible with latest tensorflow version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.